Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(2671): Move retry logic from infer_type_name to wizard #2673

Closed
wants to merge 7 commits into from

Conversation

ssddOnTop
Copy link
Member

Issue Reference(s):
Fixes #2671
/claim 2671

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 86.12%. Comparing base (e7fc1ce) to head (64d7f32).
Report is 4 commits behind head on main.

Files Patch % Lines
src/cli/llm/infer_type_name.rs 0.00% 17 Missing ⚠️
src/cli/llm/wizard.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2673      +/-   ##
==========================================
+ Coverage   86.09%   86.12%   +0.02%     
==========================================
  Files         254      255       +1     
  Lines       24486    24771     +285     
==========================================
+ Hits        21081    21333     +252     
- Misses       3405     3438      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.map(tokio_retry::strategy::jitter)
.take(10);

tokio_retry::Retry::spawn(retry, || async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retry should only happen incase of a 429 status code.

@tusharmath
Copy link
Contributor

Closing in favour of #2674

@tusharmath tusharmath closed this Aug 14, 2024
@ssddOnTop ssddOnTop deleted the chore/move-retry-logic branch August 23, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Move retry logic from infer_type_name to wizard
2 participants