refactor(2671): Move retry logic from infer_type_name to wizard #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2673 +/- ##
==========================================
+ Coverage 86.09% 86.12% +0.02%
==========================================
Files 254 255 +1
Lines 24486 24771 +285
==========================================
+ Hits 21081 21333 +252
- Misses 3405 3438 +33 ☔ View full report in Codecov by Sentry. |
6 tasks
6 tasks
tusharmath
reviewed
Aug 13, 2024
| .map(tokio_retry::strategy::jitter) | ||
| .take(10); | ||
|
|
||
| tokio_retry::Retry::spawn(retry, || async { |
There was a problem hiding this comment.
Retry should only happen incase of a 429 status code.
|
Closing in favour of #2674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference(s):
Fixes #2671
/claim 2671